Skip to content

Leasev2#590

Open
mackhendricks wants to merge 5 commits intoqafrom
leasev2
Open

Leasev2#590
mackhendricks wants to merge 5 commits intoqafrom
leasev2

Conversation

@mackhendricks
Copy link
Member

@mackhendricks mackhendricks commented Aug 26, 2024 •
edited
Loading

Perform the following tests:

  • Validate that user/pass leases can be created
  • Validate that ip based leases can be created
  • Validate that leases can be revoked
  • Validate that user/pass and ip based leases can be create from Slack
  • Receive error message when trying to trigger a lease endpoint without a Slack signing string

@devopsec Slack
Copy link
Member

devopsec commented Aug 27, 2024

Targeting v0.77 release? We should not be doing PR to master with our current workflow unless it is a release

@devopsec devopsec changed the base branch from master to qa September 19, 2024 11:26
@devopsec devopsec added the pending-qa Awaiting QA Testing Approval label Sep 19, 2024
@mackhendricks mackhendricks mentioned this pull request Sep 25, 2024
Merged
@devopsec
Copy link
Member

devopsec commented Nov 20, 2024

rebased onto qa latest changes

root and others added 5 commits January 15, 2025 16:04
@devopsec
Lease Updates:
eca9def 
- Added support for ip based leases
- Added support for creating user/name password leases from Slack slash commands
@mackhendricks @devopsec
Added logic that will send requests from Slack back in JSON format
27231db
@mackhendricks @devopsec
Added logic to parse parameters that are sent over via the Slack comm…
1c75ddd 
…and line
@mackhendricks @devopsec
Added support for Slack Signing Secret
d4004e0
@mackhendricks @devopsec
Update use-cases.rst
19d18e2 
Added documentation for using the lease API
@devopsec
Copy link
Member

devopsec commented Jan 17, 2025

@mackhendricks I put some comments in the code review above
The biggest issue is I (and a user trying to use this feature) won't know how to setup the slack integration without more info
Please add documentation for the slack portion and how to test it

@devopsec devopsec requested review from devopsec and removed request for chelseatcarter January 20, 2025 16:37
@devopsec devopsec requested review from chelseatcarter and removed request for devopsec February 3, 2025 15:43
@chelseatcarter
Copy link
Collaborator

chelseatcarter commented Feb 7, 2025

@mackhendricks
Tested successfully on dsiprouter-qa.

Test Steps:

Built this PR using the chelsea-dsiprouter-qa job.
Activated the DSIP core license located in the detailed test plan.
Used Postman to execute the GET endpoints for user/pass and IP lease creation and the DELETE endpoint for lease deletion.
Can confirm that leases can be created and revoked (while they are active).

Waiting for Slack documentation.

@devopsec devopsec removed the pending-qa Awaiting QA Testing Approval label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chelseatcarter chelseatcarter Awaiting requested review from chelseatcarter

Assignees

@mackhendricks mackhendricks

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mackhendricks @devopsec @chelseatcarter